feat: local-environment-dynamic #862
Conversation
dev/local-environment/configurations/partner-chains-setup/entrypoint.sh
Outdated
Show resolved
Hide resolved
skylar-simoncelli
force-pushed
the
lots-of-validators
branch
from
ee11f91 to
58b8841
Compare
|
@LGLO I have removed the persistent changes to /dev/local-environment that were still in my branch |
dev/local-environment-dynamic/configurations/wizard/governance-authority/entrypoint.sh
Outdated
Show resolved
Hide resolved
| # Array to store payment addresses for registered nodes | ||
| registered_node_payment_addresses=() # Array to store payment addresses | ||
|
|
||
| # --- New: Generate Payment, Cold, KES, VRF, and Stake Keys for Permissioned Nodes --- |
There was a problem hiding this comment.
This is redundant, becuase permissioned nodes do not need any Cardano keys.
There was a problem hiding this comment.
Do they not need to be registered as SPOs?
| # partner-chains-setup (extra) | ||
| tx_out4=1000000000 | ||
|
|
||
| # Fund $NUM_PERMISSIONED_NODES_TO_PROCESS permissioned nodes |
There was a problem hiding this comment.
Again, everything "permissioned" is redundant. Permissioned candidates do not run/exists on Cardano in any form.
| fi | ||
|
|
||
| # Validate batch size doesn't exceed reasonable limits | ||
| if [ "$batch_size" -gt 50 ]; then |
There was a problem hiding this comment.
If 300 nodes is the required supported number of nodes, then I think one transaction to fund all registered (up to 300) candidates is enough.
I think we can save a lot of lines of code here by doing all in one tx.
There was a problem hiding this comment.
I spent a long time initially trying to a single huge transaction, and it was proving quite difficult to dynamically get all the outputs correct
This batch method has been much more reliable in my testing
| echo "[DEBUG] CRITICAL ERROR: Failed to submit delegation transaction for $NODE_LOG_NAME after multiple attempts." | ||
| fi | ||
|
|
||
| echo "[LOG] Completed SPO registration and delegation process for $NODE_LOG_NAME." |
There was a problem hiding this comment.
I can see this log but at the same time I can observe all registrations have "InvalidStake".
curl -s -H "Content-Type:application/json" -d '{"jsonrpc":"2.0","method":"sidechain_getAriadneParameters","params":[10],"id":1}' http://localhost:9937 | jq .result.candidateRegistrations
Did you have different result for this?
There was a problem hiding this comment.
I'll have to do more testing and understand why this is
There was a problem hiding this comment.
Please fix:
- InvalidStake of registered candidates
- Remove redundant permissioned candidates related parts of Cardano setup
- Remove
testscontainers from the setup or provide and instruction to follow that would lead to at least mostly successful tests run in the container - Optionally, remove complex batching if funding of 300 nodes could be done without it
New fully dynamic local-environment, with configurable number of permissioned and registered validators, and automation of full end to end setup on mainchain and partnerchain
The main changes can be found in: