Skip to content

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Apr 23, 2025

Pull Request

Fixes #249

Changes description

  • Detects expression blocks and handles them one by one
    • Any co-occurence is tracked to the single line

m7pr
m7pr previously approved these changes Apr 23, 2025
@averissimo averissimo added the core label May 6, 2025
@averissimo averissimo marked this pull request as ready for review May 6, 2025 13:09
@averissimo averissimo requested a review from m7pr May 6, 2025 13:09
Copy link
Contributor

github-actions bot commented May 6, 2025

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ---------
R/qenv-c.R                          55       0  100.00%
R/qenv-class.R                      12       0  100.00%
R/qenv-concat.R                      7       0  100.00%
R/qenv-constructor.R                 1       0  100.00%
R/qenv-errors.R                      4       4  0.00%    6-9
R/qenv-eval_code.R                  62       2  96.77%   113, 122
R/qenv-extract.R                    30       0  100.00%
R/qenv-get_code.R                   24       0  100.00%
R/qenv-get_env.R                     3       1  66.67%   27
R/qenv-get_messages.r                5       0  100.00%
R/qenv-get_var.R                    26       0  100.00%
R/qenv-get_warnings.R                5       0  100.00%
R/qenv-join.R                        7       7  0.00%    137-151
R/qenv-length.R                      2       1  50.00%   2
R/qenv-show.R                       29      29  0.00%    19-50
R/qenv-within.R                      8       0  100.00%
R/utils-get_code_dependency.R      245       2  99.18%   160, 258
R/utils.R                           30       0  100.00%
TOTAL                              555      46  91.71%

Diff against main

Filename                         Stmts    Miss  Cover
-----------------------------  -------  ------  -------
R/utils-get_code_dependency.R      +45       0  +0.18%
TOTAL                              +45       0  +0.73%

Results for commit: 92088b3

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 6, 2025

Unit Tests Summary

  1 files   13 suites   4s ⏱️
156 tests 153 ✅ 3 💤 0 ❌
242 runs  239 ✅ 3 💤 0 ❌

Results for commit 92088b3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 6, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
utils-get_code_dependency 👶 $+0.17$ $+9$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
utils-get_code_dependency 👶 $+0.05$ detects_
utils-get_code_dependency 👶 $+0.06$ detects_assign_function
utils-get_code_dependency 👶 $+0.06$ detects_function

Results for commit ddc99a8

♻️ This comment has been updated with latest results.

@averissimo averissimo dismissed m7pr’s stale review May 6, 2025 13:45

Review on old code

@averissimo averissimo enabled auto-merge (squash) May 20, 2025 09:14
@averissimo averissimo merged commit 0461fbe into main May 20, 2025
29 checks passed
@averissimo averissimo deleted the 249-code_dependency branch May 20, 2025 09:18
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: multiple assignments inside expression throws error
2 participants