Skip to content

Conversation

averissimo
Copy link
Contributor

Pull Request

Changes description

  • Adds special case for = as it is not recognizes as language in S4 dispatch

Note to reviewers

the code with = call has a language type, but it tales priority somewhere on the dispatcher and tries to dispatch with this class (-> doesn't have a problem)

@averissimo averissimo added the core label May 6, 2025
Copy link
Contributor

github-actions bot commented May 6, 2025

Unit Tests Summary

  1 files   12 suites   3s ⏱️
153 tests 150 ✅ 3 💤 0 ❌
233 runs  230 ✅ 3 💤 0 ❌

Results for commit c11303d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 6, 2025

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
qenv_within 👶 $+0.03$ multiple_expressions

Results for commit 20ca092

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 6, 2025

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ---------
R/qenv-c.R                          55       0  100.00%
R/qenv-class.R                      12       0  100.00%
R/qenv-concat.R                      7       0  100.00%
R/qenv-constructor.R                 1       0  100.00%
R/qenv-errors.R                      4       4  0.00%    6-9
R/qenv-eval_code.R                  62       2  96.77%   113, 122
R/qenv-extract.R                    30       0  100.00%
R/qenv-get_code.R                   24       0  100.00%
R/qenv-get_env.R                     3       1  66.67%   27
R/qenv-get_messages.r                5       0  100.00%
R/qenv-get_var.R                    26       0  100.00%
R/qenv-get_warnings.R                5       0  100.00%
R/qenv-join.R                        7       7  0.00%    137-151
R/qenv-length.R                      2       1  50.00%   2
R/qenv-show.R                       29      29  0.00%    19-50
R/qenv-within.R                      8       0  100.00%
R/utils-get_code_dependency.R      200       2  99.00%   160, 258
R/utils.R                           30       0  100.00%
TOTAL                              510      46  90.98%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/qenv-eval_code.R       +5       0  +0.28%
TOTAL                    +5       0  +0.09%

Results for commit: c11303d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@averissimo I left you 3 comments/suggestions. Other than that this is good to be merged

@averissimo averissimo merged commit f410d3e into main May 20, 2025
26 checks passed
@averissimo averissimo deleted the 252-fix-assigment branch May 20, 2025 08:15
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: = assigment fails with within curly-expression
2 participants