Creates special case for '=' processing #253
Conversation
Unit Tests Summary 1 files 12 suites 3s ⏱️ Results for commit b46feff. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit 4731e87 ♻️ This comment has been updated with latest results. |
|
Code Coverage SummaryDiff against mainResults for commit: b46feff Minimum allowed coverage is ♻️ This comment has been updated with latest results |
| Reduce(function(u, v) { | ||
| if (inherits(v, "=") && identical(typeof(v), "language")) { | ||
| class(v) <- unique(c("language", class(v))) | ||
| } | ||
| eval_code(u, v) | ||
| }, init = object, x = code) |
There was a problem hiding this comment.
@averissimo what's going on : D ?
Does it mean that = has some special class attribute that is non-uniuqe?
There was a problem hiding this comment.
Yes, it's a very weird situation where typeof(v) is language (same as <- and others, but it doesn't dispatch on that
| testthat::it("single expression", { | ||
| q <- qenv() | ||
| q <- within(q, { | ||
| i <- 1 |
There was a problem hiding this comment.
@averissimo test cays that run with =. Should we use = in the test?
| i <- 1 | |
| i = 1 |
| j <- 2 | ||
| i <- 1 |
There was a problem hiding this comment.
@averissimo test claims multiple expressions. Do you mean multiple assignemnts, or just more than one assignmnent at atll?
| j <- 2 | |
| i <- 1 | |
| j <- 2 | |
| i = 1 |
| Reduce(eval_code, init = object, x = code) | ||
| Reduce(function(u, v) { | ||
| if (inherits(v, "=") && identical(typeof(v), "language")) { | ||
| class(v) <- unique(c("language", class(v))) |
There was a problem hiding this comment.
| class(v) <- unique(c("language", class(v))) | |
| # typeof(`=`) is language, but it doesn't dispatch on it, so we need to explicitly pass it as first class of the object | |
| class(v) <- unique(c("language", class(v))) |
There was a problem hiding this comment.
@averissimo I left you 3 comments/suggestions. Other than that this is good to be merged
Pull Request
=assigment fails withwithincurly-expression #252Changes description
=as it is not recognizes aslanguagein S4 dispatchNote to reviewers
the code with
=call has a language type, but it tales priority somewhere on the dispatcher and tries to dispatch with this class (->doesn't have a problem)