[cli] add a plan step to push perms #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopachka
commented
Nov 26, 2024
| console.log(diffedStr); | ||
|
|
||
| const okPush = await promptOk("OK to proceed?"); | ||
| if (!okPush) return; |
There was a problem hiding this comment.
There is a race condition in both push schema and perms, where if someone else pushed something in the meantime, we may potentially override it.
I think we can punt this race condition for now, but perhaps we can do in the future, is to pass in some version signifier, so in case it's not the same, we error out
|
View Vercel preview at instant-www-js-rules-imp-jsv.vercel.app. |
dwwoelfel
approved these changes
Nov 26, 2024
client/packages/cli/index.js
Outdated
|
|
||
| const diffedStr = jsonDiff.diffString(prodPerms.data.perms, perms) | ||
| if (!diffedStr.length) { | ||
| console.log("There are no changes to apply."); |
There was a problem hiding this comment.
Will it be obvious to the user that we're talking about perms changes here?
There was a problem hiding this comment.
Ah good point! Will update the text 🫡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we pushed perms, previously we would say: "This will overwrite your production perms. Ok?"
But that's a bit scary, as you can't really tell what has changed.
In this PR, we compare production perms with what we are pushing, and show the user:
@dwwoelfel @nezaj