Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ༼ つ ◕_◕ ༽つ Give Storage #733

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] ༼ つ ◕_◕ ༽つ Give Storage #733

wants to merge 2 commits into from

Conversation

nezaj
Copy link
Contributor

@nezaj nezaj commented Jan 18, 2025

There's still a few things to do but wanted to put up a PR for this. I'm going to restructure the commits as well to make this easier to review!

At a high-level these are the new things you'll be be able to do with Storage

Query for them like you would for other namespaces

image

And then get back urls you can use directly

image

You can interact with $files in the explorer

storage-min.MP4

transactions for $files are locked-down, you can only link/unlink in the reverse direction

Admin SDK

image

Sandbox

image image

Now our storage metrics will use $files data as well

image

More to come, but here's some of the remaining todos

Remaining todos

  • Split up PR for review
  • Add tests
    • Add tests for admin sdk
    • Add tests for dashboard explorer routes
    • Add tests for dashboard billing routes
    • Add tests for client sdk
  • Create document for testing new changes
  • Update docs
  • Go through and clean-up XXX notes and kill old code as needed
  • Change how get-signed-upload-url works to be backwards compatible
  • Write migration for existing users
  • Support setting headers for things like download
  • Add createdBy reference?
  • Add ability to do transaction with upload?

Copy link

View Vercel preview at instant-www-js-storage-jsv.vercel.app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant