chore: Allow numpy >= 2.0.0#479
Conversation
|
E2E (NVIDIA L40S x4) workflow launched on this PR: View run |
|
e2e workflow succeeded on this PR: View run, congrats! |
a9bae5c to
5b27dd6
Compare
5b27dd6 to
4612bca
Compare
|
@booxter We use numpy in a few critical points like the collator function in the dataloader as well as the data processing logic when converting from messages into raw input IDs for the model to consume. This is a PR where we'd need to run training and validate that the loss curve from your changes produces the same loss curve as what's in the main branch. |
|
Fair enough. We'll need to automate validation for patches like this one (also refactors etc.) I don't feel we should continue with human assessments (or at the very least artifacts - charts etc. - needed for such assessment should be generated and posted in comments.) I will mark this as a draft and report an issue to implement the necessary automation. |
|
@booxter Yes, we have a script to do this already but I think it broke and I haven't had time to look into it. If you can fix it then that would be a huge contribution which would automate most of the testing we do manually today. You can find it here: https://github.com/instructlab/training/blob/main/scripts/create-loss-graph.py And then the actual CI code to call it can be found here: |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
37a41c3 to
09366f6
Compare
|
Running e2e here again with enforced numpy2: https://github.com/instructlab/training/actions/runs/15446098645 |
|
E2E (NVIDIA L40S x4) workflow launched on this PR: View run |
|
Smoke check here: https://github.com/instructlab/training/actions/runs/15448724050 |
|
This pull request has merge conflicts that must be resolved before it can be |
A large e2e run with forced numpy 2.0+ suggests that the library is compatible with numpy 2.x series. Also, removed `numpy` dependency from requirements-dev.txt because it's already listed in requirements.txt. See: https://github.com/instructlab/training/actions/runs/14539292904 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
09366f6 to
545e705
Compare
|
e2e workflow succeeded on this PR: View run, congrats! |
|
Looking at charts, visually, I don't see any difference: with numpy2: https://github.com/instructlab/training/actions/runs/15446098645 |
|
Except visual comparison, is there any additional prerequisite to hit before merging this? @RobotSail |
|
@booxter Sorry I didn't see your message prior as I was out on PTO. Ideally we just need to check what APIs we are using from numpy and whether any are impacted. 95% likely it's fine but would be good to double-check. |
A large e2e run with forced numpy 2.0+ suggests that the library is compatible with numpy 2.x series.
Also, removed
numpydependency from requirements-dev.txt because it's already listed in requirements.txt.See: https://github.com/instructlab/training/actions/runs/14539292904
Signed-off-by: Ihar Hrachyshka ihar.hrachyshka@gmail.com