use LigerCrossEntropy loss with reduction=sum#578
Closed
thisisatharva-rh wants to merge 3 commits into
Closed
Conversation
JamesKunstle
left a comment
JamesKunstle
left a comment
Contributor
There was a problem hiding this comment.
This seems like a reasonable fix.
Contributor
|
@thisisatharva-rh fix your linting and DCO. To fix DCO just use |
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Closed
Collaborator
Author
|
Closing due to some git-tree issues while rebasing, opened #609 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we are using
torch.nn.CrossEntropyLoss(reduction=sum)with LK to facilitate multipack sampling, which leads to some weird behaviours as reported here. This PR enables us to useLigerCrossEntropyLosswith the multi-pack sampler, and solves the incorrect loss issue.