Skip to content

Grade list grading period filter auto selects the current period instead of reloading the last selection #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

petkybenedek
Copy link
Contributor

@petkybenedek petkybenedek commented Apr 16, 2025

What's new?

  • Grade Period filter on the Grade List screen now defaults back to the current period.

refs: MBL-18768
affects: Student, Parent
release note: Grade Period filter now auto-selects the current period on the Grade List screen.

Test plan:

  • Check if Grading Period filter resets to the current period. Previously, the selected option was saved and reloaded.
  • Check carefully everything as last time serious bugs went unnoticed. Closing the app, pull-to-refresh, all grading periods, combinations of these.

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

@petkybenedek petkybenedek self-assigned this Apr 16, 2025
@inst-danger
Copy link
Contributor

inst-danger commented Apr 16, 2025

Parent Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Apr 16, 2025

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Apr 16, 2025

Release Note:

Grade period filter now auto-selects the current period.

Affected Apps: Student, Parent

MBL-18706

Coverage New % Master % Delta
Canvas iOS 91.65% 91.61% 0.03%

Generated by 🚫 dangerJS against 2739041

@petkybenedek petkybenedek marked this pull request as ready for review April 16, 2025 10:40
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code +1

Tested on Student app, iOS 18.3.1
Seems like the issue still exist:

ScreenRecording_04-17-2025.13-56-33_1.MP4

Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code +1

Tested on Student app, iOS 18.3.1 Seems like the issue still exist:

ScreenRecording_04-17-2025.13-56-33_1.MP4

I misunderstood the requirement, seems like this what's required, which is to auto-select the current period.
Therefore, the screen recording above proves that it works.

Copy link
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The total score is not restored for me when entering the page a second time after changing grading periods:

ScreenRecording_04-17-2025.15-00-35_1.MP4

Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

@petkybenedek petkybenedek merged commit 266a030 into master Apr 23, 2025
5 checks passed
@petkybenedek petkybenedek deleted the bugfix/Grade-list-grading-period-filter-should-not-be-saved branch April 23, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants