[MBL-18172] [S/T] Split View selection highlights #3686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-18172 builds: Student, Teacher affects: Student, Teacher release note: Split View selections now stay highlighted.
# Conflicts: # Core/Core/Features/Assignments/AssignmentList/View/AssignmentListScreen.swift
Release Note:Split View selections now stay highlighted. Affected Apps: Student, TeacherBuilds: Student, Teacher
|
BuildsCommit: Remove unnecessary trailing lambda (b587026)
|
refs: builds: affects: release note: test plan:
refs: builds: affects: release note: test plan:
petkybenedek
requested review from
rh12,
suhaibabsi-inst and
vargaat
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR implements selection highlighting in Split View for multiple screens in the Student and Teacher apps. The solution introduces a SwiftUI-based environment value approach to track and display selected items when the split view is not collapsed.
Key changes:
- Added environment value-based selection tracking system using
isItemSelected - Updated existing button styles to support selection highlighting through environment values
- Modified view models to track selected item IDs and pass them to views
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Selection.swift | New file introducing environment value system for selection tracking |
| TintedContextButton.swift | Refactored to use environment values instead of parameter-based highlighting |
| InboxMessageView.swift | Updated to use new button style and selection environment |
| InboxViewModel.swift | Added selectedMessageID tracking |
| InboxView.swift | Added selection highlighting to message cells |
| GradeListViewModel.swift | Added selectedAssignmentID tracking and updated assignment selection handling |
| GradeListScreen.swift | Updated to pass selectedAssignmentID to AssignmentListView |
| AssignmentListScreenViewModel.swift | Added selectedAssignmentID tracking |
| AssignmentListView.swift | Added selection highlighting to all assignment cells |
| AssignmentListScreen.swift | Updated to pass selectedAssignmentID and contains commented debug code |
| CollapsibleListRow.swift | Added selection highlighting support |
| ActivityStreamViewController.swift | Added UIKit-based selection restoration after table view reload |
| TodoListViewController.swift | Added UIKit-based selection restoration after table view reload |
| QuizListViewController.swift | Added UIKit-based selection restoration after table view reload |
| GradeListViewModelTests.swift | Updated test to match new assignment selection signature |
Core/Core/Features/Assignments/AssignmentList/View/AssignmentListScreen.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Comment on lines
+32
to
+33
| navigateToDetailsAction: @escaping (URL?, String) -> Void, | ||
| whatIfModel: GradeListWhatIfModel? = nil, selectedAssignmentID: String? = nil |
There was a problem hiding this comment.
How about replacing the whole navigateToDetailsAction & selectedAssignmentID with a @Published property selectedAssignmentID on screen viewModel. and you can pass that property to this view as @Binding. Having an action and a property referring to the same thing seems difficult to maintain. And you get even more SwiftUI-friendly way of handling state.
There was a problem hiding this comment.
We can say the same about other list views as well: InboxView and GradeListScreen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
Selections stay highlighted in Split View on the following screens:
This PR introduces a SwiftUI-idiomatic approach to indicate selection with Environment Values. This eliminates the need of passing down parameters in the View Hierarchy.
refs: MBL-18172
builds: Student, Teacher
affects: Student, Teacher
release note: Selections on iPad now stay highlighted.
Screenshots
Checklist