[MAINT]: Update GNUmakefile to enhance test command functionality #3051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
deiga
changed the title
stevehipwell
requested changes
Jan 7, 2026
Collaborator
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
I like the test changes but I still think we need the inline CGO_ENABLED=0 to make it as easy as possible to understand.
stevehipwell
reviewed
Jan 7, 2026
stevehipwell
reviewed
Jan 7, 2026
stevehipwell
reviewed
Jan 7, 2026
stevehipwell
reviewed
Jan 7, 2026
stevehipwell
added
the
Type: Maintenance
deiga
force-pushed
the
add-config-flags-to-make
branch
2 times, most recently
from
e99429b to
3c07bca
Compare
stevehipwell
requested changes
Jan 8, 2026
deiga
force-pushed
the
add-config-flags-to-make
branch
from
3c07bca to
758ad79
Compare
- Renamed TESTARGS to COVERAGEARGS for clarity. - Added variable references and examples for test-specific variables. - Improved test and acceptance test commands to include branch information and coverage options. Signed-off-by: Timo Sand <[email protected]>
Signed-off-by: Timo Sand <[email protected]>
Signed-off-by: Timo Sand <[email protected]>
Signed-off-by: Timo Sand <[email protected]>
Signed-off-by: Timo Sand <[email protected]>
…ution Signed-off-by: Timo Sand <[email protected]>
Signed-off-by: Timo Sand <[email protected]>
Signed-off-by: Timo Sand <[email protected]>
deiga
force-pushed
the
add-config-flags-to-make
branch
from
758ad79 to
64c8c10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #3020
Before the change?
make testaccAfter the change?
make testacc T=TestAccFooCOV=truewhen calling a make commandPull request checklist
Schema migrations have been created if needed (example)Tests for the changes have been added (for bug fixes / features)Does this introduce a breaking change?
Please see our docs on breaking changes to help!