✨ Add periodic adapter
#152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbeno
force-pushed
the
periodic
branch
3 times, most recently
from
45c014b to
4205032
Compare
Problem: - There is no way to periodically run a sender without drift. Solution: - Introduce `periodic`, `periodic_n`, and `periodic_until`. Notes: - `periodic` interacts with the durationless time_scheduler. On first `start`, it schedules an expiry time of `now + duration`. On subsequence `start`s, it schedules an expiry time of `previous expiry + duration`. In this way it eliminates drift caused by the small amount of time taken to manage the timer interrupt. - The `get_expiration` query returns an `expiration_provider` rather than a bare expiration time because computing an expiration time typically involves calling `HAL::now()`, which entails making sure that `HAL::enable` has been called.
mjcaisse
reviewed
Feb 22, 2025
|
|
||
| TEST_CASE("periodic propagates forwarding queries to its child environment", | ||
| "[periodic]") { | ||
| auto s = custom_sender{}; |
There was a problem hiding this comment.
question: This doesn't seem to be testing anything in periodic. What am I missing?
There was a problem hiding this comment.
Line 88 is testing periodic; like 85 is the basis. It's testing that periodic correctly handles a forwarding query to its attributes.
| @@ -12,11 +13,25 @@ constexpr inline struct get_expiration_t : forwarding_query_t { | |||
| constexpr static auto name = stdx::ct_string{"get_expiration"}; | |||
|
|
|||
| template <typename T> | |||
| requires true | |||
There was a problem hiding this comment.
question: What does this do?
There was a problem hiding this comment.
It more tightly constrains this overload versus the one on line 28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
periodic,periodic_n, andperiodic_until.Notes:
periodicinteracts with the durationlesstime_scheduler. On firststart, it schedules an expiry time ofnow + duration. On subsequentstarts, it schedules an expiry time ofprevious expiry + duration. In this way it eliminates drift caused by the small amount of time taken to manage the timer interrupt.get_expirationquery returns anexpiration_providerrather than a bare expiration time because computing an expiration time typically involves callingHAL::now(), which entails making sure thatHAL::enable()has been called.