Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate that we don't forget linemarks #275

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Validate that we don't forget linemarks #275

wants to merge 1 commit into from

Conversation

mandolaerik
Copy link
Contributor

No description provided.

@mandolaerik mandolaerik marked this pull request as draft April 24, 2024 12:44
@mandolaerik
Copy link
Contributor Author

Draft for discussion. The handling of header/footer is wasteful, probably deserves some fast path. I'm pondering if linemark would better be folded into out; i.e., when generating code that originates from DML code, then you call out('..', loc=('file', line)), otherwise you call a plain out('...') which resets the line directive.

@syssimics
Copy link
Contributor

Verification #13289608: fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwaern-intel lwaern-intel Awaiting requested review from lwaern-intel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mandolaerik @syssimics