Generalize WNEGCONSTCOMP to warn for all constants outside a type's range #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verification #13597323: ❌ fail |
lwaern-intel
requested changes
Jul 8, 2024
lwaern-intel
reviewed
Jul 8, 2024
mandolaerik
force-pushed
the
pr/generalize-wnegconstcomp-to-warn-for-all-constants-outside-a-type-s-range
branch
from
c95d1fb to
ee9919f
Compare
|
Verification #13597509: ✅ pass |
mandolaerik
force-pushed
the
pr/generalize-wnegconstcomp-to-warn-for-all-constants-outside-a-type-s-range
branch
from
ee9919f to
0e22dde
Compare
mandolaerik
force-pushed
the
pr/generalize-wnegconstcomp-to-warn-for-all-constants-outside-a-type-s-range
branch
from
0e22dde to
2e60221
Compare
|
Verification #13597668: ✅ pass |
|
Verification #13597716: ✅ pass |
|
@mandolaerik Have you run this past Jenkins? |
|
no, do they use --werror? |
|
Some teams do for some devices for some platforms. |
|
More to the point, I want to make sure this won't cause overt logspam. We might want a compatibility feature like we did for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.