Remove obsolete warnings #321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mandolaerik
commented
Sep 5, 2024
mandolaerik
commented
- Remove obsolete warnings
- Polished documentation for some warnings
lwaern-intel
requested changes
Sep 6, 2024
There was a problem hiding this comment.
I'd be tempted to say WNDOC would be useful... if it were ever reported for registers. It's not. WNSHORTDESC sticks out to me however as a sane warning.desc, not documentation. nevermind.
You should double-check with the modeling team, Gustav in particular, if they ever have had use of any of these warnings.
py/dml/messages.py
Outdated
| This warning message will be replaced with a hard error in future | ||
| major versions of Simics. | ||
| This warning message is replaced with a hard error for modules compiled | ||
| with Simcis API 6 or newer. |
RELEASENOTES.md
Outdated
| reported. This change will cause errors if existing makefiles pass | ||
| `--nowarn=WSYSTEMC`. | ||
| - `note 6` Removed the obsolete warning types `WSHALL`, `WNDOC`, `WNSHORTDESC`, | ||
| and `WDUPEVENT`. These are all disabled by default and have no known uses, |
There was a problem hiding this comment.
Move WDUPEVENT to the former. It's never reported.
mandolaerik
force-pushed
the
pr/remove-obsolete-warnings
branch
from
3b8beb7 to
e7406ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.