Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create provisional and compat features around the vect type #328

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Create provisional and compat features around the vect type #328

wants to merge 9 commits into from

Conversation

mandolaerik
Copy link
Contributor

@mandolaerik mandolaerik commented Oct 21, 2024 •
edited
Loading

  • Include docs for compat and provisionals in 1.2 refman too
  • Allow provisional declarations in DML 1.2
  • Repair pickling of provisionals
  • Create provisional and compat features around the vect type
  • Dogfood the c_vect provisional

@mandolaerik mandolaerik changed the title Dogfood the c_vect provisional Create provisional and compat features around the vect type Oct 21, 2024
lwaern-intel
lwaern-intel requested changes Oct 21, 2024
View reviewed changes
@mandolaerik mandolaerik force-pushed the pr/dogfood-the-c_vect-provisional branch from 6e31f31 to 1d81bd5 Compare October 21, 2024 12:02
@syssimics
Copy link
Contributor

Verification #14005157: ❌ fail

@mandolaerik mandolaerik force-pushed the pr/dogfood-the-c_vect-provisional branch from 1d81bd5 to b2a4cfd Compare October 22, 2024 10:57
@syssimics
Copy link
Contributor

Verification #14009292: ❌ fail

@mandolaerik mandolaerik force-pushed the pr/dogfood-the-c_vect-provisional branch from b2a4cfd to c587b73 Compare October 22, 2024 12:37
@syssimics
Copy link
Contributor

Verification #14009657: ❌ fail

@mandolaerik
Include docs for compat and provisionals in 1.2 refman too
26296d7 
The duplicated headers are unfortunate, and is there because one
of them mentions "1.4" specifically. It's not a problem if we let
the 1.2 versions rot.
@mandolaerik
Allow provisional declarations in DML 1.2
a4ee0d1
@mandolaerik
Repair pickling of provisionals
f4f07b1
@mandolaerik
Create provisional and compat features around the vect type
e0ff61b
@mandolaerik
Dogfood the c_vect provisional
5af18dc
@mandolaerik
Deprecate the _warning statement
4692105
@mandolaerik
Rename c_vect -> simics_util_vect
015229f 
On popular demand. Also, rename ECVECT -> EOLDVECT
and c_vect_without_provisional -> experimental_vect
@mandolaerik mandolaerik force-pushed the pr/dogfood-the-c_vect-provisional branch from c587b73 to 015229f Compare October 22, 2024 15:45
@syssimics
Copy link
Contributor

Verification #14010442: ❌ fail

@syssimics
Copy link
Contributor

Verification #14010884: ✅ pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwaern-intel lwaern-intel Awaiting requested review from lwaern-intel

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mandolaerik @syssimics @lwaern-intel