Skip to content

Centralize target description query through DLTI and add verifier pass #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 6, 2024
Merged

Centralize target description query through DLTI and add verifier pass #210

merged 3 commits into from
Aug 6, 2024

Conversation

zhczhong
Copy link
Member

@zhczhong zhczhong commented Aug 2, 2024

Track: #188

@zhczhong zhczhong force-pushed the zhicong/centralize_dlti branch from 76e9272 to 36c9c9e Compare August 2, 2024 08:42
dchigarev
dchigarev approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@dchigarev dchigarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Are we already using DLTI descriptors in any of the existing GC passes?

@zhczhong zhczhong force-pushed the zhicong/centralize_dlti branch from 36c9c9e to 2b277e2 Compare August 5, 2024 02:30
@zhczhong
Copy link
Member Author

zhczhong commented Aug 5, 2024 •
edited
Loading

LGTM! Are we already using DLTI descriptors in any of the existing GC passes?

the tiling pass and fusion pass will use this DLTI descriptor and they are under review.

@zhczhong zhczhong force-pushed the zhicong/centralize_dlti branch from 2b277e2 to 870463a Compare August 5, 2024 02:42
@Yun-Fly Yun-Fly mentioned this pull request Aug 5, 2024
Merged
7 tasks
@zhczhong zhczhong force-pushed the zhicong/centralize_dlti branch from 870463a to 7598f1e Compare August 5, 2024 05:37
@zhczhong zhczhong linked an issue Aug 5, 2024 that may be closed by this pull request
DLTI support in GC #188
Closed
@zhczhong zhczhong force-pushed the zhicong/centralize_dlti branch from 7598f1e to b4a3351 Compare August 6, 2024 01:16
@zhczhong zhczhong force-pushed the zhicong/centralize_dlti branch from 50cb05b to 1731525 Compare August 6, 2024 01:42
@zhczhong zhczhong force-pushed the zhicong/centralize_dlti branch from 94ef51b to 3e2421f Compare August 6, 2024 02:16
Yun-Fly
Yun-Fly approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@Yun-Fly Yun-Fly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM now. Thanks for this contribution!

@zhczhong zhczhong merged commit 6cadff8 into main Aug 6, 2024
4 checks passed
@zhczhong zhczhong deleted the zhicong/centralize_dlti branch August 6, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhennanQin ZhennanQin ZhennanQin left review comments

@yifeizh2 yifeizh2 yifeizh2 left review comments

@dchigarev dchigarev dchigarev approved these changes

@Yun-Fly Yun-Fly Yun-Fly approved these changes

@kurapov-peter kurapov-peter Awaiting requested review from kurapov-peter

@ciyongch ciyongch Awaiting requested review from ciyongch

Assignees
No one assigned
Labels
ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DLTI support in GC
5 participants
@zhczhong @ZhennanQin @dchigarev @Yun-Fly @yifeizh2