Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update llvm commit #357

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Update llvm commit #357

merged 2 commits into from
Sep 26, 2024

Conversation

yifeizh2
Copy link
Contributor

Update llvm commit to involve the fix for unpack op canonicalization and isaConvolutionOpInterface.

PR #101 requires this update to pass CI check.

@Yun-Fly
Copy link
Contributor

Yun-Fly commented Sep 24, 2024

Do we need to update llvm version of IMEX as well?

@yifeizh2
Copy link
Contributor Author

Do we need to update llvm version of IMEX as well?

Yes. Thanks for remindering.

@Yun-Fly
Copy link
Contributor

Yun-Fly commented Sep 24, 2024

Do we need to update llvm version of IMEX as well?

Yes. Thanks for remindering.

If so, please also raise a PR in this forked IMEX repo and request review of @dchigarev.

@dchigarev
Copy link
Contributor

Do we need to update llvm version of IMEX as well?

Yes. Thanks for remindering.

If so, please also raise a PR in this forked IMEX repo and request review of @dchigarev.

Just to remind: we have a staging branch in the main imex repository, so all PRs should be submitted there.

One more thing: from our previous experience updating LLVM version for IMEX may not be that easy as simply updating llvm-commit hash. Given that GPU pipeline in GC works fine even with old LLVM for IMEX, we can leave it as it is for now and update it in a separate PR (if it would appear too complicated to make it now)

@yifeizh2 yifeizh2 force-pushed the yifei/update_llvm_commit branch from e268bed to d8662c0 Compare September 26, 2024 01:27
@yifeizh2
Copy link
Contributor Author

@dchigarev Hi. The current updated llvm commit has caused page fault runtime error in gpu mlp.mlir. The current error message is as follows

FATAL: Unexpected page fault from GPU at 0x7efc5a1f7000, ctx_id: 1 (CCS) type: 0 (NotPresent), level: 1 (PDE), access: 0 (Read), banned: 1, aborting.
^
<stdin>:1:8: note: possible intended match here
FATAL: Unexpected page fault from GPU at 0x7efc5a1f7000, ctx_id: 1 (CCS) type: 0 (NotPresent), level: 1 (PDE), access: 0 (Read), banned: 1, aborting.
       ^

The detailed CI log is accessible at: https://github.com/intel/graph-compiler/actions/runs/11043869278/job/30678842932?pr=357.
Can you help troubleshoot this issue? Sorry for causing inconvenience.

@dchigarev
Copy link
Contributor

dchigarev commented Sep 26, 2024

Hi. The current updated llvm commit has caused page fault runtime error in gpu mlp.mlir. The current error message is as follows

The is-usm-args=false parameter for gpu pipeline was missing for some reason in mlp.mlir test. Committed fix to this branch

@yifeizh2
Copy link
Contributor Author

Hi. The current updated llvm commit has caused page fault runtime error in gpu mlp.mlir. The current error message is as follows

The is-usm-args=false parameter for gpu pipeline was missing for some reason in mlp.mlir test. Committed fix to this branch

Thanks a lot for help fixing this!

@yifeizh2 yifeizh2 merged commit 664024a into main Sep 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants