[MLIR][IR] Add easy-builder to simplify IR building in C++ #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Author
|
The preview upstream PR at Menooker/llvm-project#2 . It has not been submitted to upstream MLIR and is only in my fork, for now. |
yifeizh2
reviewed
Jun 14, 2024
| } | ||
|
|
||
| #define DEF_EASYBUILD_CMP_OPERATOR(OP, OPCLASS, TYPE, PRED) \ | ||
| EBUnsigned operator OP(const TYPE &a, const TYPE &b) { \ |
Contributor
There was a problem hiding this comment.
Missing an inline here (also commented on the upstream preparation repo, sorry for spam~)
Author
There was a problem hiding this comment.
It's not spam! Thanks for finding that! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered doc at https://github.com/intel/graph-compiler/blob/yijie/easy-build/docs/EasyBuilder.md