Skip to content

build: use Go 1.25 and trixie #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

build: use Go 1.25 and trixie #2104

merged 1 commit into from
Aug 18, 2025

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Aug 14, 2025

golangci-lint 2.4.0 deprecates wsl and suggests wsl_v5 which finds many new places to fix. Leave these alone and simply disable wsl. noctx linter errors on net.Listen() and prefers ListenConfig.

@mythi mythi marked this pull request as ready for review August 15, 2025 07:33
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, change look fine.

(I did not check that all instances have been changed, I assume you've used git grep to check all of them.)

golangci-lint 2.4.0 deprecates wsl and suggests wsl_v5 which finds
many new places to fix. Leave these alone and simply disable wsl.
noctx linter errors on net.Listen() and prefers ListenConfig.

Signed-off-by: Mikko Ylinen <[email protected]>
@mythi
Copy link
Contributor Author

mythi commented Aug 18, 2025

I assume you've used git grep to check all of them.

yes, I believe I covered everything

Copy link
Contributor

@tkatila tkatila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried gpu-plugin and gpu-levelzero. They still work together.

@tkatila tkatila merged commit d638585 into intel:main Aug 18, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants