Skip to content

Fix parameter inconsistency in result reporting #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

Egor-Krivov
Copy link
Contributor

@Egor-Krivov Egor-Krivov commented Jan 29, 2025

Removed MODE parameter from attn benchmark, because this information is passed via benchmark name, reverted int conversion change from https://github.com/intel/intel-xpu-backend-for-triton/pull/3108/files#diff-fd4b71bc079eacc2ebcbceba947990270f332f6d7d72133aa8e149a87d7c6e95.

Relates to #3285

@Egor-Krivov Egor-Krivov marked this pull request as draft January 29, 2025 12:25
@Egor-Krivov Egor-Krivov changed the title Removed mode parameter, reverted int conversion Fix parameter inconsistency in result reporting Jan 29, 2025
@Egor-Krivov Egor-Krivov marked this pull request as ready for review February 3, 2025 09:35
@Egor-Krivov Egor-Krivov enabled auto-merge (squash) February 3, 2025 09:35
@Egor-Krivov
Copy link
Contributor Author

@Egor-Krivov Egor-Krivov merged commit 84b376c into main Feb 3, 2025
5 of 6 checks passed
@Egor-Krivov Egor-Krivov deleted the egor/fix_db branch February 3, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants