Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UR][SYCL] Remove UR context atomic queries. #16160

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from
Open

[UR][SYCL] Remove UR context atomic queries. #16160

wants to merge 2 commits into from

Conversation

aarongreig
Copy link
Contributor

These were always just used as placeholder values so they can be replaced by __SYCL_TRAIT_HANDLED_IN_RT.

@aarongreig aarongreig mentioned this pull request Nov 22, 2024
Open
@aarongreig
[UR][SYCL] Remove UR context atomic queries.
a75dafc 
These were always just used as placeholder values so they can be replaced by
__SYCL_TRAIT_HANDLED_IN_RT.
@aarongreig aarongreig force-pushed the aaron/removeURContextAtomicQueries branch from 5252593 to a75dafc Compare November 25, 2024 16:27
@aarongreig aarongreig marked this pull request as ready for review January 22, 2025 12:15
@aarongreig aarongreig requested review from a team as code owners January 22, 2025 12:15
@aelovikov-intel
Copy link
Contributor

These were always just used as placeholder values so they can be replaced by __SYCL_TRAIT_HANDLED_IN_RT.

Is it because it is the right way to do this or just because it so happened?

@aarongreig
Copy link
Contributor Author

These were always just used as placeholder values so they can be replaced by __SYCL_TRAIT_HANDLED_IN_RT.

Is it because it is the right way to do this or just because it so happened?

The queries are all implemented via GetCapabilitiesIntersectionSet. Before the UR port having fake PI enums whose only purpose was to be used in the __SYCL_PARAM_TRAITS_SPEC macro was a common pattern

@aarongreig
Copy link
Contributor Author

CI fail is unrelated, I think something's wrong with that windows runner

@aelovikov-intel
Copy link
Contributor

CI fail is unrelated, I think something's wrong with that windows runner

Both yes and no :)

yes: #16757
no:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarongreig @aelovikov-intel