-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Deprecate current implementations of get_backend_info() #16700
Conversation
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
…NGES flag Signed-off-by: Hu, Peisen <[email protected]>
Requesting @intel/llvm-gatekeepers to merge this PR. Thanks! |
|
@aelovikov-intel Sure, can you send me a link to the failed test run? Thanks! |
https://github.com/intel/llvm/actions/runs/12933016036/job/36074301399 |
@aelovikov-intel I've inspected that issue and I believe it's irrelevant to my changes? I mean there're two points:
|
This is weird, https://github.com/intel/llvm/actions/workflows/sycl-post-commit.yml clearly shows the pass->fail change between https://github.com/intel/llvm/actions/runs/12932360753 and https://github.com/intel/llvm/actions/runs/12933016036. Tagging @KseniyaTikhomirova as well. |
@aelovikov-intel I believe there is a delay between the start of the whole post-commit run and the start of the e2e-win run. So my assumption is that, if some code is pushed during this delay window, it may be actually used in the e2e-win run and cause such weird behavior? |
AFAIK, we lock in exact commit hashes, unless that was silently dropped recently. Hmm, #16560 might have done just that. @KornevNikita , any ideas if that's true? |
I've uploaded #16757 to fix the race condition. @KornevNikita, I'm surprised why you needed this in the first place... |
The
get_backend_info()
functions implemented in #12906 are returning some info descriptors that are not backend-specific info descriptors but SYCL core info descriptors. This leads to problems as described in #16272 . Therefore, its current implementations are being deprecated, and removed under the__INTEL_PREVIEW_BREAKING_CHANGES
flag.