Skip to content

[SYCL][Graph] Initial implementation of graph-owned device allocations #18002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[SYCL][Graph] Initial implementation of graph-owned device allocations #18002

wants to merge 3 commits into from

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Apr 14, 2025 •
edited
Loading

  • Allocations managed via new graph_mem_pool
  • Device allocations use virtual memory
  • Intercept async_alloc calls when adding nodes to graph
  • New tests for functionality
  • Update CommandGraph design docs

Draft spec: #18001

@Bensuo Bensuo force-pushed the ben/graph_async_alloc_impl branch from 0d47482 to f22eba9 Compare April 14, 2025 16:54
@Bensuo Bensuo force-pushed the ben/graph_async_alloc_impl branch from f22eba9 to 39caa11 Compare April 14, 2025 16:55
@Bensuo Bensuo force-pushed the ben/graph_async_alloc_impl branch from 39caa11 to e037248 Compare April 15, 2025 10:01
@Bensuo Bensuo temporarily deployed to WindowsCILock April 15, 2025 10:40 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 15, 2025 10:40 — with GitHub Actions Inactive
@Bensuo Bensuo force-pushed the ben/graph_async_alloc_impl branch from e037248 to f0df304 Compare April 15, 2025 15:28
@Bensuo Bensuo force-pushed the ben/graph_async_alloc_impl branch from f0df304 to fe51208 Compare April 15, 2025 15:57
@Bensuo Bensuo force-pushed the ben/graph_async_alloc_impl branch from fe51208 to f93ce75 Compare April 15, 2025 16:09
@Bensuo Bensuo force-pushed the ben/graph_async_alloc_impl branch from f93ce75 to 5638e1b Compare April 15, 2025 16:34
@Bensuo Bensuo temporarily deployed to WindowsCILock April 15, 2025 16:34 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 15, 2025 17:16 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 15, 2025 17:16 — with GitHub Actions Inactive
@Bensuo Bensuo force-pushed the ben/graph_async_alloc_impl branch from 5638e1b to 306b5a2 Compare April 16, 2025 10:57
@Bensuo Bensuo temporarily deployed to WindowsCILock April 16, 2025 10:57 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 16, 2025 11:31 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 16, 2025 11:31 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 16, 2025 11:51 — with GitHub Actions Inactive
@Bensuo
[SYCL][Graph] Initial implementation of graph-owned device allocations
3d6204f 
- Allocations managed via new graph_mem_pool
- Device allocations use virtual memory
- Intercept async_alloc calls when adding nodes to graph
- New tests for functionality
- Design doc information about implementation
@Bensuo Bensuo force-pushed the ben/graph_async_alloc_impl branch from 306b5a2 to 3d6204f Compare April 17, 2025 11:13
@Bensuo Bensuo temporarily deployed to WindowsCILock April 17, 2025 11:13 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 17, 2025 11:27 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 17, 2025 11:27 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 17, 2025 11:53 — with GitHub Actions Inactive
@Bensuo Bensuo marked this pull request as ready for review April 17, 2025 13:22
@Bensuo Bensuo requested review from a team as code owners April 17, 2025 13:22
aelovikov-intel
aelovikov-intel approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for non-graph portion (like 1% of the PR maybe).

@Bensuo Bensuo temporarily deployed to WindowsCILock April 21, 2025 10:13 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 21, 2025 10:43 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 21, 2025 11:10 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 21, 2025 11:10 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 21, 2025 12:21 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 21, 2025 12:56 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 21, 2025 13:06 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 21, 2025 13:06 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@konradkusiak97 konradkusiak97 Awaiting requested review from konradkusiak97 konradkusiak97 is a code owner automatically assigned from intel/sycl-graphs-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bensuo @aelovikov-intel