Skip to content

[SYCL][E2E] Update some incompatible requirements #18007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from

Conversation

KornevNikita
Copy link
Contributor

These test are never launched due to the REQUIRES set. Update these sets and remove accelerator-related parts if needed, otherwise some test may fail due to lack of device.

There test are neved launched due to the REQUIRES set.
Update these sets and remove accelerator-related parts if needed,
otherwise some test may fail due to lack of device.
@KornevNikita KornevNikita marked this pull request as ready for review April 15, 2025 14:56
@KornevNikita KornevNikita requested review from a team as code owners April 15, 2025 14:56
@KornevNikita KornevNikita requested a review from slawekptak April 15, 2025 14:56
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit.

@@ -38,7 +32,8 @@ int main() {
device d(cpu_selector_v);
}
{
device d(accelerator_selector_v);
// We no longer run tests on acc. Leaving this just in case.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd completely remove it. We are removing acc-related stuff from other tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants