[CI][E2E] Run Windows Battlemage with prebuilt binaries #18042
+7
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
approved these changes
Apr 16, 2025
|
LGTM, I'll review again once the PR is published |
uditagarwal97
approved these changes
Apr 16, 2025
sarnex
approved these changes
Apr 16, 2025
aelovikov-intel
approved these changes
Apr 16, 2025
|
4 runs in a row that did not hang, pretty sure there aren't any more flaky hangs. https://github.com/intel/llvm/actions/runs/14497224154/attempts/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also disable tests that were flaky hanging in this configuration.
When running fully on BMG tests took around 15min. With this change building e2e tests takes around 10m, and running the tests took around 6m. On paper this isn't any faster, however since we are spending less time on the BMG machine (which we currently only have one of in CI) this should improve the queue times for it. Additionally there is further opportunity to speed up the e2e build stage by moving it into the same job that builds the compiler, like we do for Linux.