[NFC][SYCL] Simplify variadic_iterator usage
#19507
Open
+19
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::weak_ptr<node_impl>` aren't used to create `nodes_range` anymore (intel#19438 being the last change that enabled that, I think) and we also added `SyclTy` template parameter to `variadic_iterator` so that the dereference operator can be implemented in a generic way in the base class.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/sycl-graphs-reviewers this is relatively trivial and after it'll get merged, I'd be able to upload subsequent PR without triggering graph reviews, can you please take a quicker look at this? @sergey-semenov , your review is necessary too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::weak_ptr<node_impl>aren't used to createnodes_rangeanymore (#19438 being the last change that enabled that, I think) and we also addedSyclTytemplate parameter tovariadic_iteratorso that the dereference operator can be implemented in a generic way in the base class.