[NFC][clang-linker-wrapper] Move Arch definition out of the loop. #20954
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a TODO comment with plan for further alignment with the upstream code. The idea is replace SPIR-V AOT sub-targets with --arch option to separate JIT and AOT modes.
sarnex
approved these changes
Dec 22, 2025
Contributor
Author
|
Most likely, pre-commit failure is not related to my change. I see an issue opened in 2023 #11364 - it can be related to the test time out, but I'm not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a TODO comment with plan for further alignment with the upstream
code. The idea is replace SPIR-V AOT sub-targets with --arch option to
separate JIT and AOT modes.