Fixed Coverity and lint issues #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatinwadhwa921
requested review from
sfatimar,
ankitm3k,
preetha-intel and
saurabhkale17
|
Hi, the internal ci seems to fail here due to ci server connectivity issue, so i ran the internal ci on Jenkins |
sfatimar
reviewed
Jan 31, 2025
| @@ -32,7 +32,7 @@ GetCapability::GetCapability(const EPCtxHandler& ep_ctx_handler, | |||
| const std::string device_type_param, | |||
| const bool enable_qdq_optimizer) : ep_ctx_handler_(ep_ctx_handler), | |||
| graph_viewer_(graph_viewer_param), | |||
| device_type_(device_type_param) { | |||
| device_type_(std::move(device_type_param)) { | |||
There was a problem hiding this comment.
Fixed, std::move() uses utility header file so added that in capability.cc
sfatimar
force-pushed
the
jatin_fix_cov_lint_weight
branch
from
9b1839f to
0b65389
Compare
|
@jatinwadhwa921 can i merge this |
Sahar, this is an old pr , the coverity fix has been already merged in ovep develop yesterday "48f060b" . i will be closing this pr , this pr is no more necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Coverity and lint issues