CVS-177904: Address code review comments for backend_manager.cc #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-intel
requested changes
Dec 9, 2025
| if (it == proto_initializer_map.end()) | ||
| continue; | ||
|
|
||
| auto* proto_init = it->second; |
There was a problem hiding this comment.
Can you please make this a reference for consistency? You check below with a direct iterator use can be moved up.
javier-intel
approved these changes
Dec 9, 2025
MayureshV1
approved these changes
Dec 10, 2025
|
The changes look good. Also getting Dmitri to review this to ensure it meets his review comment. |
MayureshV1
changed the title
…check, and add braces around if/else with a macro
intbf
force-pushed
the
address_code_review_backend_manager
branch
from
19b999b to
608746a
Compare
Refactor LoadFileToMemory to return std::optional, enabling explicit error handling for file loading failures. Update tests to assert successful file loads and access data via optionals.
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
CVS-177904, CVS-174602