Skip to content

Enhance build flags for Debug and RelWithDebInfo configurations #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 29, 2025
Merged

Enhance build flags for Debug and RelWithDebInfo configurations #1671

Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
856d4fd
Update BuildFlags.cmake
chunhuanMeng May 15, 2025
fa48af1
Merge branch 'main' into meng_debug
chunhuanMeng May 16, 2025
1188d7a
Update BuildFlags.cmake
chunhuanMeng May 16, 2025
e0f146c
fix lint error
chunhuanMeng May 16, 2025
5e3ac8f
Update BuildFlags.cmake
chunhuanMeng May 16, 2025
fc934a1
Update CMakeLists.txt
chunhuanMeng May 20, 2025
6d86495
Merge branch 'main' into meng_debug
chunhuanMeng May 20, 2025
e3ae11f
fix lint error
chunhuanMeng May 20, 2025
2d05b6d
Merge branch 'main' into meng_debug
chunhuanMeng May 20, 2025
65bd695
Merge branch 'main' into meng_debug
chunhuanMeng May 21, 2025
f6f2819
Merge branch 'main' into meng_debug
chunhuanMeng May 22, 2025
d8d6d89
Merge branch 'main' into meng_debug
xytintel May 28, 2025
ec0b139
Update skip_list_common.py
xytintel May 28, 2025
7265d23
Update skip_list_win.py
xytintel May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmake/BuildFlags.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,12 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR CMAKE_CXX_COMPILER_ID STREQUAL "MSVC"
set(SYCL_KERNEL_OPTIONS ${SYCL_KERNEL_OPTIONS} -Wno-absolute-value)
set(SYCL_KERNEL_OPTIONS ${SYCL_KERNEL_OPTIONS} -no-ftz)
endif()

if(CMAKE_BUILD_TYPE MATCHES Debug)
set(SYCL_KERNEL_OPTIONS ${SYCL_KERNEL_OPTIONS} -g)
set(SYCL_KERNEL_OPTIONS ${SYCL_KERNEL_OPTIONS} -Rno-debug-disables-optimization)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we use -Rno-debug-disables-optimization on kernel option but -O0 in host option? we should keep them the same. https://github.com/intel/torch-xpu-ops/blob/main/cmake/BuildFlags.cmake#L47

endif(CMAKE_BUILD_TYPE MATCHES Debug)

set(SYCL_KERNEL_OPTIONS ${SYCL_KERNEL_OPTIONS} -D__INTEL_LLVM_COMPILER_VERSION=${__INTEL_LLVM_COMPILER})

CHECK_SYCL_FLAG("-fsycl-fp64-conv-emu" SUPPORTS_FP64_CONV_EMU)
Expand Down
Loading