Disable xccl timer avoid drlm hang #1706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR disables the XPUEvent timer to avoid potential hangs by disabling the elapsed_time function and using disabled event instances.
- Re-initializes all XPUEvent objects with timing disabled
- Comments out the call to elapsed_time and hardcodes the result to 0
| @@ -56,7 +57,10 @@ class XpuTimer : public Timer { | |||
|
|
|||
| start_event.synchronize(); | |||
| end_event.synchronize(); | |||
| float milliseconds = start_event.elapsed_time(end_event); | |||
|
|
|||
| // Event elapsed_time may cause stuck, disable it for now | |||
There was a problem hiding this comment.
Please add a reference to the associated bug report or a TODO comment explaining under what conditions the elapsed_time function can be re-enabled. This extra detail will help future maintainers understand the temporary workaround.
Copilot uses AI. Check for mistakes.
zhangxiaoli73
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.