-
Notifications
You must be signed in to change notification settings - Fork 46
Remove -cl-poison-unsupported-fp64-kernels
flag
#1772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chunhuanMeng
wants to merge
5
commits into
main
Choose a base branch
from
meng_build_flag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the now-unnecessary -cl-poison-unsupported-fp64-kernels
flag from the offline compiler options, since FP64 kernels are auto-detected and filtered.
- Deleted the obsolete
-cl-poison-unsupported-fp64-kernels
setting. - No other behavior changes to compiler flags.
@sys_pytorchxpubot triage result for run 15893471765Triage bot UT analaysis result for reference only, please note unique error message only report once:
Triage bot response: {
"similar_issue_id": 1214,
"similar_issue_state": "open",
"issue_owner": "daisyden",
"issue_description": "In the test case test_det_xpu_complex128, an AssertionError occurs with the message 'Scalars are not close!', indicating a discrepancy in scalar values during the test. This issue is likely related to tensor operations on XPU, particularly involving complex128 dtype, similar to previous issues where tensor comparisons failed due to precision or computation errors.",
"root_causes": [
"Potential issues in tensor computation or comparison logic specific to XPU operations.",
"Numerical precision discrepancies affecting scalar comparisons in complex128 dtype operations."
],
"suggested_solutions": [
"Investigate the computation and comparison logic for determinant operations on XPU tensors.",
"Review and adjust numerical precision handling in tensor operations to ensure accurate scalar comparisons."
]
}
Triage bot response: {
"similar_issue_id": 1214,
"similar_issue_state": "open",
"issue_owner": "daisyden",
"issue_description": "The test test_tensorsolve_xpu_complex128 failed with an AssertionError: Tensor-likes are not close! The error suggests a discrepancy in tensor values between XPU and CPU computations, specifically for complex128 tensors. The failure is not random and points to a potential issue in the tensor solve operation's implementation on XPU.",
"root_causes": [
"Discrepancies in tensor computations between CPU and XPU, possibly due to differences in numerical precision or kernel implementations.",
"Potential issues in the XPU-specific implementation of the tensor solve operation."
],
"suggested_solutions": [
"Review the implementation of the tensor solve operation on XPU to ensure numerical consistency with CPU computations.",
"Investigate any recent changes or updates to the XPU kernels that might have introduced this discrepancy.",
"Compare the results of the tensor solve operation on both CPU and XPU to identify and correct any inconsistencies."
]
}
Triage bot response: {
"similar_issue_id": 1214,
"similar_issue_state": "open",
"issue_owner": "daisyden",
"issue_description": "The test test_numpy_ref_linalg_tensorsolve_xpu_complex128 is failing with an AssertionError indicating that the tensors from numpy and XPU are not matching within the allowed tolerance. The error occurs during the comparison of tensor operations involving complex128 dtype. The failure is consistent and not random, suggesting a deterministic issue in the implementation.",
"root_causes": [
"Discrepancies in the handling of complex128 dtype operations between numpy and XPU implementations.",
"Potential differences in precision or kernel behavior affecting the results of linalg_tensorsolve operations."
],
"suggested_solutions": [
"Review and align the implementation of linalg_tensorsolve for complex128 dtype across numpy and XPU to ensure consistent results.",
"Investigate and correct any precision-related issues in the XPU kernel implementations that handle complex128 tensors."
]
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-cl-poison-unsupported-fp64-kernels
option is no longer necessary. The compiler now has the capability to detect and filter out all FP64 computation kernels automatically. Consequently, the IGC does not need to be invoked for any FP64 computation kernels.