clean skip list in skip_list_common.py #1825
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chunhuanMeng <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the skip list in skip_list_common.py by removing tests that now pass and clearing out obsolete entries.
- Removed numerous outdated skip entries for tests that are passing
- Replaced long tuples of skip names with
Nonefor files no longer needing skips - Pruned excess comments related to removed entries
Comments suppressed due to low confidence (2)
test/xpu/skip_list_common.py:4
- There's a typo in the comment: 'claimn' should be 'claim' or better yet rephrased as 'doesn't support FP8 yet'.
# XPU implementation doesn't claimn FP8 now
test/xpu/skip_list_common.py:7
- [nitpick] This comment appears outdated now that entries have been removed. Consider deleting it or clarifying what should still be removed.
# To be removed from this file.
|
@mengfei25 please check the UT test check failure, whether there are some new failures or skipped some still failed cases by this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean skip list in skip_list_common.py, removed passed cases.