Replace deprecated [[intel::reqd_sub_group_size(SgSize)]] with [[sycl::reqd_sub_group_size(SIMD)]] and remove unnecessary attributes
#1828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d_sub_group_size]]`
There was a problem hiding this comment.
Pull Request Overview
This PR updates SYCL kernel attributes by replacing the deprecated [[intel::reqd_sub_group_size]] with [[sycl::reqd_sub_group_size]] and removes unnecessary subgroup-size annotations to reduce warnings and simplify code.
- Replaced all
[[intel::reqd_sub_group_size(...)]]instances with[[sycl::reqd_sub_group_size(...)]]. - Removed redundant subgroup-size attributes in
ForeachReduceKernels.cpp.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ATen/native/xpu/sycl/TensorModeKernel.cpp | Swapped intel::reqd_sub_group_size for sycl::reqd_sub_group_size |
| src/ATen/native/xpu/sycl/SortingKernels.h | Updated subgroup attribute namespace to sycl |
| src/ATen/native/xpu/sycl/SoftMaxKernels.cpp | Replaced deprecated attribute with sycl version |
| src/ATen/native/xpu/sycl/Norm.h | Replaced deprecated subgroup attribute |
| src/ATen/native/xpu/sycl/MultiLabelMarginLossKernels.cpp | Updated attribute namespace |
| src/ATen/native/xpu/sycl/LossNLL2dKernels.cpp | Swapped to sycl::reqd_sub_group_size |
| src/ATen/native/xpu/sycl/LinearInt4.cpp | Updated subgroup-size attribute |
| src/ATen/native/xpu/sycl/LayerNormKernels.cpp | Replaced intel attribute with sycl version |
| src/ATen/native/xpu/sycl/IndexKernelUtils.h | Swapped attribute namespace |
| src/ATen/native/xpu/sycl/GroupNormKernels.cpp | Updated deprecated annotation |
| src/ATen/native/xpu/sycl/ForeachReduceKernels.cpp | Removed unnecessary reqd_sub_group_size annotations |
| src/ATen/native/xpu/sycl/Dequant_int4.cpp | Replaced intel attribute with sycl version |
| src/ATen/native/xpu/sycl/BatchNormKernels.cpp | Swapped subgroup-size attribute namespace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the codebase to replace the deprecated
[[intel::reqd_sub_group_size(SgSize)]]attribute with the new[[sycl::reqd_sub_group_size(SIMD)]]attribute. Additionally, the attribute has been removed from certain locations where it was deemed unnecessary.These changes also aim to reduce the number of warnings, thereby decreasing the log size.Changes
Attribute Replacement:
[[intel::reqd_sub_group_size(SgSize)]]with[[sycl::reqd_sub_group_size(SIMD)]]to align with the latest SYCL specification and avoid using deprecated attributes.Attribute Removal:
[[sycl::reqd_sub_group_size(SIMD)]]attribute from functions and kernels where it was not necessary. This was done to simplify the code and avoid redundant specifications.