fix: don't reconnect when http client is closed #1780
+24
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
#1778 mentions an interesting bug that came up because of a bug fix from aiohttp. This is because, when a session closes, aiohttp will now dispatch a close event rather than abruptly ending. Our code was not expecting this possibility, and so when handling a pre-established edge case, it errored out.
This PR fixes any errors that come from such a behavior.
Changes
closed
attribute toHTTPClient
.WebsocketClient
send an internal "no-op" op code if the websocket receives aCLOSED
even and the HTTP client is closed.GatewayClient
simply ignore it.Related Issues
Closes #1778.
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files