Draft: WEBDEV-7479 Tile updates for TV collections/clips #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
latonv
commented
May 23, 2025
Comment on lines
-67
to
+54
| <li class="col" title="${formattedFavCount} favorites"> | ||
| ${favoriteFilledIcon} | ||
| <p class="status-text"> | ||
| <span class="sr-only">${msg('Favorites:')}</span> | ||
| ${formattedFavCount} | ||
| </p> | ||
| </li> | ||
| <li class="col reviews" title="${formattedReviewCount} reviews"> | ||
| ${reviewsIcon} | ||
| <p class="status-text"> | ||
| <span class="sr-only">${msg('Reviews:')}</span> | ||
| ${formattedReviewCount} | ||
| </p> | ||
| </li> | ||
| ${this.mediatypeIconColumnTemplate} | ||
| ${this.mediatype === 'account' | ||
| ? this.uploadsColumnTemplate | ||
| : this.viewsColumnTemplate} | ||
| ${this.favoritesColumnTemplate} | ||
| ${this.showTvClips | ||
| ? this.tvClipsColumnTemplate | ||
| : this.reviewsColumnTemplate} |
There was a problem hiding this comment.
This render method was getting somewhat unwieldy given all the mixing of conditional logic and HTML throughout it. I refactored things to pull out the individual column templates and make the logic more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor tile changes are required to display results within TV collections, which may be "clips" of a larger program. Tiles in these collections should also display how many times they have been "clipped" in place of their review count.