WEBDEV-7610 Check default sort applied by PPS instead of metadata #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
latonv
commented
Jul 4, 2025
| searchServiceKey: 'favoritedate', | ||
| displayName: 'Date favorited', | ||
| urlNames: ['favoritedate'], | ||
| urlNames: ['favoritedate', 'date_favorited'], |
There was a problem hiding this comment.
The PPS identifies this sort using date_favorited, a format that differs from the other date sorts because of the different backing store for favorites & date favorited. Adding the new one so that we recognize it correctly, and leaving the old one for backwards-compatibility. We don't actually send this sort string to the PPS as it is always the default in context.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
==========================================
+ Coverage 92.69% 92.70% +0.01%
==========================================
Files 109 109
Lines 17490 17483 -7
Branches 1369 1372 +3
==========================================
- Hits 16212 16208 -4
+ Misses 1215 1212 -3
Partials 63 63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently to determine the default sort option to select for a collection, we check for its
sort-bymetadata and fall back to global defaults otherwise. However, TV collections have their own default that is not always specified in metadata. And since we can't always identify TV collections until after receiving a PPS response, we need to rely on the PPS layer to both apply and inform the client of the correct default sort.This PR updates how we determine which sort option to select, relying on the PPS's finalized request parameters rather than the collection metadata for this purpose.