Skip to content

Conversation

latonv
Copy link
Contributor

@latonv latonv commented Sep 24, 2025

TV searches do not require all the same sort options available, in particular since many of the date options are either not relevant or essentially the same for TV items.

This PR generalizes how the sort bar component is configured a bit, so that we can easily modify what sort options are available in bulk rather than via individual flags, and then ensures it is configured appropriately in the cases that require non-default sort options.

Copy link

github-actions bot commented Sep 25, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-07 00:27 UTC

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 99.32432% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.07%. Comparing base (39349b1) to head (394511b).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/sort-filter-bar/sort-filter-bar.ts 99.09% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
+ Coverage   92.98%   93.07%   +0.09%     
==========================================
  Files         112      112              
  Lines       18537    18705     +168     
  Branches     1455     1472      +17     
==========================================
+ Hits        17236    17410     +174     
+ Misses       1230     1224       -6     
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@latonv latonv force-pushed the webdev7757-tv-sort-options branch from dd5564b to 394511b Compare September 26, 2025 17:05
@latonv latonv merged commit f5502ff into main Oct 7, 2025
4 checks passed
@latonv latonv deleted the webdev7757-tv-sort-options branch October 7, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants