Skip to content

Conversation

latonv
Copy link
Contributor

@latonv latonv commented Oct 3, 2025

The facetPaneVisible property currently only has an effect when showSmartFacetBar is enabled. However, there is little reason why these two properties need to be coupled that way. This PR allows facetPaneVisible to take effect regardless of whether smart facets are shown.

Copy link

github-actions bot commented Oct 3, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-07 00:39 UTC

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.65%. Comparing base (97b42ad) to head (caf16fc).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
+ Coverage   92.64%   92.65%   +0.01%     
==========================================
  Files         112      112              
  Lines       18641    18637       -4     
  Branches     1456     1454       -2     
==========================================
- Hits        17270    17269       -1     
+ Misses       1300     1297       -3     
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@latonv latonv merged commit 43f2951 into main Oct 7, 2025
4 checks passed
@latonv latonv deleted the webdev7818-facet-visibility branch October 7, 2025 00:38
@latonv latonv changed the title Allow facetPaneVisible prop to function without smart facets WEBDEV-7818 Allow facetPaneVisible prop to function without smart facets Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants