Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make modalTemplate optional in iaux-modal-manager #105

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

nsharma123
Copy link
Contributor

Copy link

github-actions bot commented Mar 20, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-03-28 04:25 UTC

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.57%. Comparing base (4eef9ed) to head (e97a718).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/modal-manager.ts 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   97.32%   95.57%   -1.75%     
==========================================
  Files           5        5              
  Lines         112      113       +1     
  Branches       26       28       +2     
==========================================
- Hits          109      108       -1     
  Misses          2        2              
- Partials        1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@rebecca-shoptaw rebecca-shoptaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One (optional) suggestion, otherwise looks good!

Copy link

@rebecca-shoptaw rebecca-shoptaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nsharma123 nsharma123 merged commit 54f1f73 into main Mar 28, 2025
2 of 4 checks passed
@nsharma123 nsharma123 deleted the webdev-7373-optional-modal-template branch March 28, 2025 04:24
@nsharma123 nsharma123 mentioned this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants