Fix ctx.features missing in fakeload #225
Merged
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes internetarchive/openlibrary#10341
Tested locally with some debugging print statements:
And now
debug
appears correctly as enabled, even when running off the main thread!Note, I did spot another bug; when the cache is populated for the very first time and run on the main thread, it cached the debug value as True if that first request happened to have it set to true. This is a pre-existing issue, that likely causes a number of headaches with our cache. Created a PR to fix on OL: #10591
Also fixes https://sentry.archive.org/organizations/ia-ux/issues/482181/?environment=production&project=7&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&statsPeriod=1h&stream_index=5