-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Edition aware carousels #10619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Edition aware carousels #10619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
reviewed
Mar 24, 2025
mekarpeles
commented
Mar 25, 2025
mekarpeles
commented
Mar 25, 2025
cdrini
reviewed
Mar 25, 2025
When a ListQuery carousel exhausts all its IDs, the query fallback to something that produces lots of results when instead none should be returned. This commit checks if no book keys remain in the list and falls back to a special query that will return no results.
This makes more sense for browse-ish carousels
for more information, see https://pre-commit.ci
This reverts commit e1e5c1e.
- Adds providers to carousels query - Edition-aware; update book -> work to edition where possible - Fix ia carousels, use query instead of url - Move compose_ia_url to backend - Add subjects as loadmore field - Standardizes application/json response - Adds editions to fields - Fixes carousel fetching
da34782
to
814f68a
Compare
…austed-results Fix list querying case when out of results
mekarpeles
commented
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7252 and #10580 (merging already reviewed code)
Technical
Testing
Screenshot
Stakeholders