Conversation
jimchamp
reviewed
Feb 18, 2026
Comment on lines
-26
to
-29
| class PartialResolutionError(Exception): | ||
| pass | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Removing this will make debugging more difficult.
Collaborator
Author
There was a problem hiding this comment.
Could you clarify what you mean? I'm guessing this is Sentry related?
We used this in the resolver before, but now that each partial has its own endpoint, I don’t think we’d run into the same type of error.
We were also using it when the wrong number of arguments were passed to AffiliateLinksPartial. That doesn’t seem like the right error type for that situation, since the issue isn’t really related to the reslution of partials themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #11773
Now that fastapi is enabled we can remove the legacy code supporting web.py
In the future there's several refactors I'd also like to make includieng
Technical
Testing
Screenshot
Stakeholders