Skip to content

remove web.py partials code#11895

Open
RayBB wants to merge 1 commit intomasterfrom
partials/remove-webpy
Open

remove web.py partials code#11895
RayBB wants to merge 1 commit intomasterfrom
partials/remove-webpy

Conversation

@RayBB
Copy link
Collaborator

@RayBB RayBB commented Feb 18, 2026

Followup to #11773

Now that fastapi is enabled we can remove the legacy code supporting web.py

In the future there's several refactors I'd also like to make includieng

  • Making some of the partials async
  • refactoring so we don't need to init (just pass in the variables directly)

Technical

Testing

Screenshot

Stakeholders

@RayBB RayBB requested a review from cdrini February 18, 2026 20:42
Comment on lines -26 to -29
class PartialResolutionError(Exception):
pass


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this will make debugging more difficult.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify what you mean? I'm guessing this is Sentry related?

We used this in the resolver before, but now that each partial has its own endpoint, I don’t think we’d run into the same type of error.

We were also using it when the wrong number of arguments were passed to AffiliateLinksPartial. That doesn’t seem like the right error type for that situation, since the issue isn’t really related to the reslution of partials themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments