Skip to content

fix bug of dead loop when get http 4xx error from Elasticsearch #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix bug of dead loop when get http 4xx error from Elasticsearch #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/java/com/internetitem/logback/elasticsearch/writer/ElasticsearchWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ public void sendData() throws IOException {
int rc = urlConnection.getResponseCode();
if (rc != 200) {
String data = slurpErrors(urlConnection);
if(rc >= 400 && rc < 500){
// no chance to recover form these errors and has to drop the log messages in order to avoid dead loop.
errorReporter.logInfo("Send queue cleared - drop log messages due to http 4xx error.");
sendBuffer.setLength(0);
bufferExceeded = false;
}
throw new IOException("Got response code [" + rc + "] from server with data " + data);
}
} finally {
Expand Down