Skip to content

Remove label from new routine stub #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove label from new routine stub #1612

wants to merge 1 commit into from

Conversation

isc-bsaviano
Copy link
Contributor

This PR fixes #1611

@isc-bsaviano
Copy link
Contributor Author

This is not the cause of the linked issue, but I still think this is worth approving.

gjsjohnmurray
gjsjohnmurray reviewed Jul 15, 2025
View reviewed changes
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should make this change. It is a longstanding convention that the first line of a routine has a label that matches the routine name. See Annexe E (informative) of ANSI / MDC X11.1-1995.

@isc-bsaviano
Copy link
Contributor Author

Fair enough, let's abide by the standard in the absence of a clear reason to abandon it.

@isc-bsaviano isc-bsaviano deleted the fix-1611 branch July 15, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjsjohnmurray gjsjohnmurray gjsjohnmurray left review comments

@isc-rsingh isc-rsingh isc-rsingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZAUTHENTICATE created in VS Code has first line that prevents delegated authentication from working
3 participants
@isc-bsaviano @isc-rsingh @gjsjohnmurray