config: add default value for caching max_age #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
reviewed
Jul 20, 2022
| @@ -14,6 +14,9 @@ from flask_babelex import lazy_gettext as _ | |||
| # ===== | |||
| # See https://flask.palletsprojects.com/en/1.1.x/config/ | |||
|
|
|||
| # https://flask.palletsprojects.com/en/2.1.x/config/#SEND_FILE_MAX_AGE_DEFAULT | |||
There was a problem hiding this comment.
Can we add an extra small comment?
Suggested change
| # https://flask.palletsprojects.com/en/2.1.x/config/#SEND_FILE_MAX_AGE_DEFAULT | |
| # Define the cache control header `max-age` returned by the server when serving | |
| # public files. Files will be cached by the browser for the provided number of seconds. | |
| # See flask documentation for more information: | |
| # https://flask.palletsprojects.com/en/2.1.x/config/#SEND_FILE_MAX_AGE_DEFAULT |
NRodriguezcuellar
force-pushed
the
set_cache_control_default
branch
from
8468f4e to
7a95f5c
Compare
Pineirin
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set a default value for the flask variable
SEND_FILE_MAX_AGE_DEFAULTpartly closes inveniosoftware/invenio-communities#718