Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community logo: replacing an image does not work #718

Closed
kpsherva opened this issue Jun 16, 2022 · 1 comment · Fixed by #740 or inveniosoftware/cookiecutter-invenio-rdm#220 · May be fixed by inveniosoftware/invenio-files-rest#283
Closed

community logo: replacing an image does not work #718

kpsherva opened this issue Jun 16, 2022 · 1 comment · Fixed by #740 or inveniosoftware/cookiecutter-invenio-rdm#220 · May be fixed by inveniosoftware/invenio-files-rest#283
Assignees
@kpsherva
Labels
Type: bug

Comments

@kpsherva
Copy link
Contributor

kpsherva commented Jun 16, 2022 •
edited
Loading

Tested locally:

  1. Upload a community logo
  2. try to replace a logo with another image
  3. test on inveniordm-qa.web.cern.ch
@NRodriguezcuellar NRodriguezcuellar self-assigned this Jun 23, 2022
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-communities that referenced this issue Jun 30, 2022
community settings: disable caching for community logo endpoint
b86fe47 
added the no cache param to the community logo endpoint in the community settings so that it will always show the updated version of the community logo, otherwise it will sometimes cache the image and the user will be confused as to why the community logo did not change

partly closes inveniosoftware#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-files-rest that referenced this issue Jun 30, 2022
send file: add params for cache control headers
c557327 
added 2 params called max_age and no_cache which will allow more control about what cache control headers are being returned by the file response object

partly closes inveniosoftware/invenio-communities#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-communities that referenced this issue Jun 30, 2022
community settings: disable caching for community logo endpoint
2aefcfa 
added the no cache param to the community logo endpoint in the community settings so that it will always show the updated version of the community logo, otherwise it will sometimes cache the image and the user will be confused as to why the community logo did not change

partly closes inveniosoftware#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-records-resources that referenced this issue Jun 30, 2022
file results: add params
62ce9e9 
added 2 params which are used to control what and how cache control headers are being set

closes inveniosoftware/invenio-communities#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-communities that referenced this issue Jun 30, 2022
community settings: disable caching for community logo endpoint
be98471 
added the no cache param to the community logo endpoint in the community settings so that it will always show the updated version of the community logo, otherwise it will sometimes cache the image and the user will be confused as to why the community logo did not change

partly closes inveniosoftware#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-communities that referenced this issue Jun 30, 2022
community settings: disable caching for community logo endpoint
016ab92 
added the no cache param to the community logo endpoint in the community settings so that it will always show the updated version of the community logo, otherwise it will sometimes cache the image and the user will be confused as to why the community logo did not change

Also, added a small text under the logo uploader to inform the user that it may take a small while before the new version is shown to them.

partly closes inveniosoftware#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-communities that referenced this issue Jun 30, 2022
community settings: disable caching for community logo endpoint
1931054 
added the no cache param to the community logo endpoint in the community settings so that it will always show the updated version of the community logo, otherwise it will sometimes cache the image and the user will be confused as to why the community logo did not change

Also, added a small text under the logo uploader to inform the user that it may take a small while before the new version is shown to them.

partly closes inveniosoftware#718
This was referenced Jun 30, 2022
Merged
Closed
Open
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-communities that referenced this issue Jun 30, 2022
community settings: disable caching for community logo endpoint
68ce774 
added the no cache param to the community logo endpoint in the community settings so that it will always show the updated version of the community logo, otherwise it will sometimes cache the image and the user will be confused as to why the community logo did not change

Also, added a small text under the logo uploader to inform the user that it may take a small while before the new version is shown to them.

partly closes inveniosoftware#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-files-rest that referenced this issue Jun 30, 2022
send file: add params for cache control headers
4190920 
added 2 params called max_age and no_cache which will allow more control about what cache control headers are being returned by the file response object

partly closes inveniosoftware/invenio-communities#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-communities that referenced this issue Jun 30, 2022
community settings: disable caching for community logo endpoint
d78d6bc 
added the no cache param to the community logo endpoint in the community settings so that it will always show the updated version of the community logo, otherwise it will sometimes cache the image and the user will be confused as to why the community logo did not change

Also, added a small text under the logo uploader to inform the user that it may take a small while before the new version is shown to them.

partly closes inveniosoftware#718
@NRodriguezcuellar NRodriguezcuellar removed their assignment Jun 30, 2022
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-communities that referenced this issue Jul 7, 2022
community logo: set restriction based on community type and force fre…
3fe1c00 
…sh image

closes inveniosoftware#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-files-rest that referenced this issue Jul 7, 2022
send file: change cache control behaviour
7ff13c3 
if files are restricted the cache-control header will now be set to "no-cache" so that resources are always checked to be fresh before being served,
otherwise it will be cached for a certain amount of time, defined by a config value

partly closes inveniosoftware/invenio-communities#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-communities that referenced this issue Jul 7, 2022
community logo: set restriction and force fresh image
025c0d4 
closes inveniosoftware#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-communities that referenced this issue Jul 7, 2022
community logo: set restriction and force fresh image
5464ce3 
now will set the restriction param based on the community visibility and it will force the community logo in the settings page to always update so that any changes
are immediately shown to the user, no matter the browser cache.

closes inveniosoftware#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-communities that referenced this issue Jul 7, 2022
community logo: set restriction and force fresh image
b73ac1c 
now will set the restriction param based on the community visibility and it will force the community logo in the settings page to always update so that any changes
are immediately shown to the user, no matter the browser cache.

closes inveniosoftware#718
@NRodriguezcuellar NRodriguezcuellar mentioned this issue Jul 20, 2022
Merged
@NRodriguezcuellar NRodriguezcuellar moved this from 👌 Reviever approved to 👀 Pending review in InvenioRDM v10 - Back-office Jul 20, 2022
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-files-rest that referenced this issue Jul 21, 2022
send file: change cache control behaviour
5f954e3 
if files are restricted the cache-control header will now be set to "no-cache" so that resources are always checked to be fresh before being served.

partly closes inveniosoftware/invenio-communities#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/cookiecutter-invenio-rdm that referenced this issue Jul 21, 2022
config: add default value for caching max_age
7a95f5c 
partly closes inveniosoftware/invenio-communities#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-files-rest that referenced this issue Jul 22, 2022
send file: change cache control behaviour
0bc1d2c 
if files are restricted the cache-control header will now be set to "no-cache" so that resources are always checked to be fresh before being served.

partly closes inveniosoftware/invenio-communities#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-files-rest that referenced this issue Jul 25, 2022
send file: change cache control behaviour
2974dbc 
if files are restricted the cache-control header will now be set to "no-cache" so that resources are always checked to be fresh before being served.

partly closes inveniosoftware/invenio-communities#718
@kpsherva kpsherva moved this from 👀 Pending review to 👌 Reviever approved in InvenioRDM v10 - Back-office Jul 28, 2022
Repository owner moved this from 👌 Reviever approved to ✅ Done in InvenioRDM v10 - Back-office Jul 29, 2022
kpsherva pushed a commit that referenced this issue Jul 29, 2022
@kpsherva
community logo: set restriction and force fresh image
3009e30 
now will set the restriction param based on the community visibility and it will force the community logo in the settings page to always update so that any changes
are immediately shown to the user, no matter the browser cache.

closes #718
@kpsherva kpsherva moved this from ✅ Done to 👌 Reviever approved in InvenioRDM v10 - Back-office Jul 29, 2022
@kpsherva kpsherva moved this from 👌 Reviever approved to 🏗 In progress in InvenioRDM v10 - Back-office Aug 10, 2022
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-files-rest that referenced this issue Aug 10, 2022
send file: change cache control behaviour
089b3fa 
if files are restricted the cache-control header will now be set to "no-cache" so that resources are always checked to be fresh before being served.

partly closes inveniosoftware/invenio-communities#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-files-rest that referenced this issue Aug 10, 2022
send file: change cache control behaviour
a92f0b3 
if files are restricted the cache-control header will now be set to "no-cache" so that resources are always checked to be fresh before being served.

partly closes inveniosoftware/invenio-communities#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-files-rest that referenced this issue Aug 10, 2022
send file: change cache control behaviour
e65d8c7 
if files are restricted the cache-control header will now be set to "no-cache" so that resources are always checked to be fresh before being served.

partly closes inveniosoftware/invenio-communities#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-files-rest that referenced this issue Aug 10, 2022
send file: change cache control behaviour
3e6c8a0 
if files are restricted the cache-control header will now be set to "no-cache" so that resources are always checked to be fresh before being served.

partly closes inveniosoftware/invenio-communities#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-files-rest that referenced this issue Aug 10, 2022
send file: change cache control behaviour
d9dded1 
if files are restricted the cache-control header will now be set to "no-cache" so that resources are always checked to be fresh before being served.

partly closes inveniosoftware/invenio-communities#718
NRodriguezcuellar pushed a commit to NRodriguezcuellar/invenio-files-rest that referenced this issue Aug 10, 2022
send file: change cache control behaviour
bf4e970 
if files are restricted the cache-control header will now be set to "no-cache" so that resources are always checked to be fresh before being served.

partly closes inveniosoftware/invenio-communities#718
@ntarocco ntarocco moved this from 🏗 In progress to ✅ Done in InvenioRDM v10 - Back-office Aug 16, 2022
@kpsherva kpsherva moved this from ✅ Done to 👀 Pending review in InvenioRDM v10 - Back-office Sep 1, 2022
@ppanero
Copy link
Member

ppanero commented Feb 16, 2023

there is one pr still not merged

@ppanero ppanero reopened this Feb 16, 2023
@github-project-automation github-project-automation bot moved this from 📋 To do to ✅ Done in InvenioRDM v10 - Back-office Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpsherva kpsherva

Labels
Type: bug
Projects
No open projects
InvenioRDM v10 - Back-office
Status: ✅ Done
Milestone
No milestone
3 participants
@ppanero @kpsherva @NRodriguezcuellar