Allow for different ways of providing consumer_key config - #337
Open
J4bbi wants to merge 1 commit into
Open
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is currently a hard-coded reference to the optional
app_keyparameter of the Flask-OAuthlib library. Resultingin a
KeyErrorbeing raised if it is not present.invenio-oauthclient/invenio_oauthclient/handlers/utils.py
Line 86 in 4aaa9c5
Using the
app_keyis a way to lazy load theconsumer_keyandconsumer_secret, but it is possible toprovide them directly. It will have to be either, otherwise the remote app won't load.
This PR also removes a duplication of defining the
remote_appsvariable and fixes some documentation.Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: