edit(loans): loan dates now only editable when active or pending

[callumlewis05]

Loans dates can now only be edited if the loan is active or pending. When the edit button is clicked a popup appears with an error message if the loan is returned or cancelled.

UI after clicking the edit dates return button for each type of loan:

Pending loan:

Cancelled loan:

Item on loan (active):

Returned:

• closes Editable loan dates on 'returned' loan should not be possible CERNDocumentServer/cds-ils#1004

[kpsherva]

LGTM, could you add a screenshot of changes?
Please try to provide screenshots any time there is a change in the interface, it makes it easier to evaluate in terms of the UX.

[callumlewis05]

LGTM, could you add a screenshot of changes? Please try to provide screenshots any time there is a change in the interface, it makes it easier to evaluate in terms of the UX.

Done 👍

[kpsherva]

thanks! now it is much easier to understand the change.
Wouldn't it be easier to disable the edit period of interest button if the loan is cancelled or returned? Imagine yourself being the librarian and clicking to edit, only to find out from the modal that you can't... Sometimes this might be frustrating. Is it a lot of work to block the button before this happens? Of course, we need this message on why it is blocked as well - we usually use the Tooltip cmp for this reason.

[callumlewis05]

thanks! now it is much easier to understand the change. Wouldn't it be easier to disable the edit period of interest button if the loan is cancelled or returned? Imagine yourself being the librarian and clicking to edit, only to find out from the modal that you can't... Sometimes this might be frustrating. Is it a lot of work to block the button before this happens? Of course, we need this message on why it is blocked as well - we usually use the Tooltip cmp for this reason.

Okay I will look at greying out the button and adding the tooltip if the button is clicked on

[callumlewis05]

Greyed out button so it is not clickable and added tooltip for cancelled and returned loans.

Cancelled:

Returned: