feat(frontend): Add better frontend tracing#11244
Open
matmair wants to merge 11 commits intoinventree:masterfrom
Open
feat(frontend): Add better frontend tracing#11244matmair wants to merge 11 commits intoinventree:masterfrom
matmair wants to merge 11 commits intoinventree:masterfrom
Conversation
matmair
added
enhancement
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #11244 +/- ##
==========================================
- Coverage 88.14% 87.96% -0.19%
==========================================
Files 1290 1290
Lines 58352 58684 +332
Branches 1965 1966 +1
==========================================
+ Hits 51437 51619 +182
- Misses 6426 6575 +149
- Partials 489 490 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
Should we be concerned about the extra (albeit small) overhead associated with the extra API call to end the trace? Have you profiled this in action? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gives us a generic way to associated API calls with a single event in the frontend. This is helpful to more easily find bottlenecks like serial API calls that do not depend on each other, API calls that are always grouped and access the same data and much more.
Changeset is kept minimal to get some practice with the process around the gathered analytics before we maybe extend OTEL to the frontend - which is much more involved data and security wise.